chore(danger): report PR's build size #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
force-pushed
the
chore-danger-size
branch
from
316aa67
to
0765cef
Compare
Generated by 🚫 dangerJS |
-0KB-red.svg?style=flat-square){kind=icon}
-0KB-red.svg?style=flat-square){kind=icon}
kwonoj
force-pushed
the
chore-danger-size
branch
4 times, most recently
from
72d0917
to
752fb50
Compare
benlesh
approved these changes
Jun 16, 2017
benlesh
requested changes
Jun 16, 2017
|
@benlesh I was plan to ask review after I complete 😅 |
kwonoj
force-pushed
the
chore-danger-size
branch
4 times, most recently
from
5d20b65
to
74cacdf
Compare
kwonoj
force-pushed
the
chore-danger-size
branch
from
74cacdf
to
3be42fe
Compare
|
@benlesh PR is ready, check danger comment for example. |
kwonoj
force-pushed
the
chore-danger-size
branch
from
4650f07
to
04b9ca9
Compare
benlesh
approved these changes
Jun 17, 2017
|
Love it! |
GulajavaMinistudio
added a commit
to GulajavaMinistudio/rxjs
that referenced
this pull request
Jun 18, 2017
chore(danger): report PR's build size (ReactiveX#2674)
jayphelps
pushed a commit
to jayphelps/rxjs
that referenced
this pull request
Oct 12, 2017
* chore(danger): report PR's build size * chore(danger): compare size to latest release
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As a first step for #2670, this PR makes danger to report current size of build by PR.
there's further improvement like compare to base branch, etcs - this is initial impl for basic support.
Related issue (if exists):
#2670