Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RxJs Logo to README, Similar to RxSwift README #2794

Merged
merged 2 commits into from
Mar 30, 2018

Conversation

Knighton910
Copy link
Contributor

Description:

Related issue (if exists):

@rxjs-bot
Copy link

Warnings
⚠️

commit message does not follows conventional change log (1)

Messages
📖

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

CJS: 3175.8KB, global: 588.9KB (gzipped: 108.6KB), min: 138.0KB (gzipped: 29.1KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.736% when pulling 5b067fb on lordKnighton:master into 74ff463 on ReactiveX:master.

@kwonoj
Copy link
Member

kwonoj commented Aug 13, 2017

I think we are using RxJS elsewhere? (not sure if it's legit though)

@Knighton910
Copy link
Contributor Author

So can we get this Merged?

@kwonoj
Copy link
Member

kwonoj commented Aug 17, 2017

@lordKnighton I think it need to be updated with updating commit message (for changelog) / updating RxJs word, otherwise lgtm. I'm adding @benlesh for double confirm just in case.

@kwonoj kwonoj requested a review from benlesh August 17, 2017 00:44
@benlesh benlesh merged commit 51848fc into ReactiveX:master Mar 30, 2018
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants