Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cast types so library works with TS 2.4x and 2.5x #2896

Merged

Conversation

jasonaden
Copy link
Collaborator

In testing Rx against projects using TS 2.4 and 2.5 (with strict compilation settings), there are a number of compilation errors. This PR adds casting to address these errors, so Rx can be used in projects using either TS 2.4 or 2.5.

@rxjs-bot
Copy link

rxjs-bot commented Oct 4, 2017

Messages
📖

CJS: 1338.3KB, global: 737.8KB (gzipped: 138.2KB), min: 145.3KB (gzipped: 30.9KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Oct 4, 2017

Coverage Status

Coverage decreased (-0.0007%) to 97.465% when pulling 0627845 on jasonaden:fix_typescript_version_compatability into fb3694d on ReactiveX:master.

@kwonoj kwonoj added the TS Issues and PRs related purely to TypeScript issues label Oct 4, 2017
@kwonoj kwonoj merged commit c5b1e42 into ReactiveX:master Oct 4, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
TS Issues and PRs related purely to TypeScript issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants