Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain where let operator went in lettable-operators.md #3014

Merged
merged 1 commit into from
Dec 21, 2017

Conversation

wardbell
Copy link
Contributor

@wardbell wardbell commented Oct 27, 2017

Description:

Tell folks migrating to 5.5 that the let operator is now pipe.
Also tell them about:

  • Observable.toPromise (no more toPromise operator
  • Observable.throw is on the prototype and import { throw } from 'rxjs/observable/throw' won't work (for obvious reasons).

Related issue (if exists):

@rxjs-bot
Copy link

rxjs-bot commented Oct 27, 2017

Messages
📖

CJS: 1346.1KB, global: 746.2KB (gzipped: 120.0KB), min: 145.7KB (gzipped: 31.2KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.372% when pulling 73c8b35 on wardbell:docs-where-is-let into 040d951 on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.372% when pulling 8b209bf on wardbell:docs-where-is-let into 040d951 on ReactiveX:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.372% when pulling 3727eea on wardbell:docs-where-is-let into 040d951 on ReactiveX:master.

Also explains that:
- `toPromise` is now an `Observable` instance method and cannot be imported.
- `throw` is a JS keyword so use `_throw` or `ErrorObservable` instead.
@coveralls
Copy link

coveralls commented Oct 28, 2017

Coverage Status

Coverage remained the same at 97.372% when pulling 73c8b35 on wardbell:docs-where-is-let into 040d951 on ReactiveX:master.

@benlesh benlesh merged commit c9f69ad into ReactiveX:master Dec 21, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants