refactor(timeInterval): implement in terms of scan #3177
Conversation
src/operators/timeInterval.ts
Outdated
| ({ current }, value) => ({ value, current: scheduler.now(), last: current }), | ||
| { current: scheduler.now() } | ||
| ) as any, | ||
| map(({ current, last, value }) => new TimeInterval(value, current - last)), |
There was a problem hiding this comment.
nit: will there be difference if we just map to object instead of class?
interface TimeInterval<T> {
readonly value: T;
readonly interval: number
}
....
map<TimeInterval>((...) => ({value, interval: current - last}));
There was a problem hiding this comment.
Not really. There's probably some negligible perf benefit to it being a class, butt I'm speculating I can change it. It'll probably further reduce size
There was a problem hiding this comment.
If we don't lose anything (and I'm pretty sure transpiled sizewise object will be smaller than class) I'd like to suggest to go for object, as TimeInterval class really doesn't nothing in here.
benlesh
force-pushed
the
smaller-timeInterval
branch
from
826b6a6
to
f09b8bc
Compare
|
@kwonoj, I could not remove the class just yet, because it's being exported for backwards compat reasons. We'll remove it soon. |
benlesh
force-pushed
the
smaller-timeInterval
branch
from
f09b8bc
to
b7e2a9d
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
reducing the size of timeInterval. A non-hotpath operator.