build: use tsc importHelpers flag to remove duplicate helpers from esm5 and esm2015 builds #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
---10.7KB-green.svg?style=flat-square){kind=icon}
---2.1KB-green.svg?style=flat-square){kind=icon}
…m5 and esm2015 builds I intentionally didn't use the flag for cjs builds because that would make cjs builds incompatible with SystemJS without further configuration on the client-side - this would be highly undesirable.
IgorMinar
force-pushed
the
tsc-importHelpers
branch
from
f3644fc
to
fa692b5
Compare
benlesh
approved these changes
Mar 8, 2018
|
what was conclusion for #2436 (comment) ? no issues expected? @benlesh |
|
@kwonoj I explained it here: #2436 (comment) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intentionally didn't use the flag for cjs builds because that would
make cjs builds incompatible with SystemJS without further configuration
on the client-side - this would be highly undesirable.