Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable stripInternal because it breaks d.ts files in the publ… #3418

Merged
merged 3 commits into from
Mar 13, 2018

Conversation

IgorMinar
Copy link
Contributor

…ished package

This change essentially rolls back 97c2284

@rxjs-bot
Copy link

rxjs-bot commented Mar 9, 2018

Messages
📖

CJS: 1296.8KB, global: 690.0KB (gzipped: 113.1KB), min: 132.1KB (gzipped: 29.1KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented Mar 9, 2018

Coverage Status

Coverage decreased (-0.001%) to 97.544% when pulling 184b6d4 on IgorMinar:build/disable-stripInteral into b1e5d3a on ReactiveX:master.

…ished package

This change essentially rolls back 97c2284
…ckage.json

This affects SystemJS compatibility because we now need to add packages configuration for all
entry-points but there seems to be no way to satify everyone.

The operators/package.json file is needed in order to make prod build resolution work, so we
prefer to keep this working and ask SystemJS users to add extra configuration.

The SystemJS config after this change should be:

System.config({
  map: { 'rxjs': '/some/root/path/to/rxjs/' },
  packages: {
    'rxjs': {main: 'index.js', defaultExtension: 'js' },
    'rxjs/ajax': {main: 'index.js', defaultExtension: 'js' },
    'rxjs/operators': {main: 'index.js', defaultExtension: 'js' },
    'rxjs/testing': {main: 'index.js', defaultExtension: 'js' },
    'rxjs/websocket': {main: 'index.js', defaultExtension: 'js' }
  }
});
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants