fix(ajax): Handle timeouts as errors #3653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
requested changes
May 9, 2018
felixfbecker
approved these changes
May 15, 2018
benlesh
approved these changes
May 21, 2018
|
Thanks, @bbonnet! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
XHR Timeouts are not being handled properly.
It turns out the XHR timeouts fire the
readystatechangeevent (with status=0, readyState=4) and then thetimeoutevent. This is causingnextto be called beforeerror.Confirmed this behavior in Chrome, added a test for timeouts and fixed the behavior by pointing the main event handler to fire on
load. Definitely recommend confirming this behavior and compatibility in other browsers.Fixed up our
MockXMLHttpRequestto cause timeouts after thesendmethod is called.Overall, I want to recommend moving away from this
MockXMLHttpRequestso that we aren't re-implementing browser functionality in the tests. I saw that the current browser tests are broken, wanted to take a stab at either fixing those or porting over some integration tests to Karma. Totally open to suggestions there.This is my first contribution to rxjs, really open to feedback and suggestions!
Related issue (if exists):
#3606