Overload take while to accept a type guard #4085
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request overloads the takeWhile operator with an additional signature to accept a type guard.
I tried to keep the code as similar as possible to the corresponding overload signature of the filter operator. Please let me know, if I should change something.
I wasn't sure if the JSDoc should be changed as well. The return type of the filter operator is just
Observable
(without a generic) whereas the one of the takeWhile operator isObservable<T>
.Related issue (if exists):
This PR fixes #4081.