Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(issue-template): fix typo in Issue template #4246

Merged
merged 1 commit into from
Nov 21, 2018
Merged

chore(issue-template): fix typo in Issue template #4246

merged 1 commit into from
Nov 21, 2018

Conversation

dzhavat
Copy link
Contributor

@dzhavat dzhavat commented Oct 11, 2018

Description:
Fix typo in the documentation issue template.

Related issue (if exists):

@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 7683

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.967%
Files with Coverage Reduction New Missed Lines %
src/internal/observable/fromPromise.ts 1 87.5%
src/internal/Subscription.ts 2 92.11%
src/internal/observable/fromIterable.ts 2 95.24%
src/internal/observable/fromObservable.ts 2 83.33%
Totals Coverage Status
Change from base Build 7399: 0.2%
Covered Lines: 5786
Relevant Lines: 5967
💛 - Coveralls

pertrai1
pertrai1 approved these changes Oct 20, 2018
View reviewed changes
Copy link
Contributor

@pertrai1 pertrai1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great catch

@dzhavat dzhavat closed this Nov 21, 2018
@dzhavat dzhavat deleted the github-template-documentation branch November 21, 2018 17:38
@dzhavat dzhavat restored the github-template-documentation branch November 21, 2018 17:38
@dzhavat dzhavat reopened this Nov 21, 2018
@dzhavat
Copy link
Contributor Author

dzhavat commented Nov 21, 2018

Stupid mistake from my side (doh). I though I no longer need this branch. Sorry :)

@cartant cartant merged commit 2490957 into ReactiveX:master Nov 21, 2018
@dzhavat dzhavat deleted the github-template-documentation branch November 21, 2018 19:44
@lock lock bot locked as resolved and limited conversation to collaborators Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pertrai1 pertrai1 pertrai1 approved these changes

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dzhavat @coveralls @pertrai1 @cartant