fix(WebSocketSubject): fix subject failing to close socket #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix WebSocketSubject failing to close the underlying socket connection when it is unsubscribed before the socket is in the open state. Currently, when unsubscribe is called on the subject or when a subscription is unsubscribed there are checks on whether the socket is open (readyState = 1) before it closes the connection. If unsubscribe is called before the connection is open, it will not close the socket but will reset the state of the subject (_socket set to null), and it becomes impossible to close the socket.
Pull Request Test Coverage Report for Build 7832
💛 - Coveralls |
benlesh
approved these changes
Jan 29, 2019
|
Thank you, @rsikdar! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix WebSocketSubject failing to close the underlying socket connection when it is unsubscribed
before the socket is in the open state. Currently, when unsubscribe is called on the subject or
when a subscription is unsubscribed there are checks on whether the socket is open (readyState = 1)
before it closes the connection. If unsubscribe is called before the connection is open, it will not
close the socket but will reset the state of the subject (_socket set to null), and it becomes
impossible to close the socket.
Related issue (if exists): #4447