Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs) add doc for timeinterval operator #4505

Closed
wants to merge 1 commit into from
Closed

feat(docs) add doc for timeinterval operator #4505

wants to merge 1 commit into from

Conversation

githubxiaowen
Copy link
Contributor

Description:
add documentation for timeinterval

Related issue (if exists):

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linting is failing on CI; some trailing whitespace needs to be removed:

ERROR: src/internal/operators/timeInterval.ts[26, 36]: trailing whitespace
ERROR: src/internal/operators/timeInterval.ts[27, 32]: trailing whitespace
ERROR: src/internal/operators/timeInterval.ts[33, 32]: trailing whitespace
ERROR: src/internal/operators/timeInterval.ts[34, 6]: trailing whitespace
ERROR: src/internal/operators/timeInterval.ts[39, 3]: trailing whitespace

@cartant
Copy link
Collaborator

cartant commented Jan 29, 2019

Is see you've closed this, have made the requested changes and have opened another PR. That's fine, but you might find it easier - in the future - to make the changes in a new commit - on the same branch - and then to push that commit to your GitHub repo. That will see your PR updated with the new commit and the changes.

Anyway, thanks for your work. It's appreciated!

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants