Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(windowWhen): fix example #4548

Merged
merged 1 commit into from
Feb 27, 2019
Merged

docs(windowWhen): fix example #4548

merged 1 commit into from
Feb 27, 2019

Conversation

tanem
Copy link
Contributor

@tanem tanem commented Feb 9, 2019

Fixes the windowWhen example imports.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8077

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.805%
Totals Coverage Status
Change from base Build 8066: 0.0%
Covered Lines: 5242
Relevant Lines: 5415
💛 - Coveralls

niklas-wortmann
niklas-wortmann approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit 886ddc3 into ReactiveX:master Feb 27, 2019
@benlesh
Copy link
Member

benlesh commented Feb 27, 2019

Thanks again, @tanem!

@tanem tanem deleted the fix-window-when-example branch March 7, 2019 16:09
@lock lock bot locked as resolved and limited conversation to collaborators Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklas-wortmann niklas-wortmann niklas-wortmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanem @coveralls @benlesh @niklas-wortmann