Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy style & docs in catchError #4553

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Conversation

tanem
Copy link
Contributor

@tanem tanem commented Feb 9, 2019

Keeping things consistent with the other files I've been looking at 馃拕

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8082

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.962%

Files with Coverage Reduction New Missed Lines %
src/internal/observable/fromPromise.ts 1 87.5%
src/internal/observable/fromIterable.ts 2 95.24%
src/internal/observable/fromObservable.ts 2 83.33%
Totals Coverage Status
Change from base Build 8066: 0.2%
Covered Lines: 5777
Relevant Lines: 5958

馃挍 - Coveralls

@benlesh benlesh merged commit b96edf7 into ReactiveX:master Feb 14, 2019
@benlesh
Copy link
Member

benlesh commented Feb 14, 2019

Thank you, @tanem

@tanem tanem deleted the tidy-catch-error branch March 7, 2019 16:09
@lock lock bot locked as resolved and limited conversation to collaborators Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants