Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(operators): add missing import to the example #4638

Merged
merged 2 commits into from Mar 18, 2019
Merged

docs(operators): add missing import to the example #4638

merged 2 commits into from Mar 18, 2019

Conversation

saxicek
Copy link
Contributor

@saxicek saxicek commented Mar 14, 2019

mergeScan import was missing in the example so it did not work

Description:
mergeScan import was missing in the example so it did not work

Related issue (if exists):

@saxicek
docs(operators): add missing import to the example
c9a0c39 
mergeScan import was missing in the example so it did not work
@coveralls
Copy link

coveralls commented Mar 14, 2019 •
edited

Pull Request Test Coverage Report for Build 8245

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 96.797%
Files with Coverage Reduction New Missed Lines %
src/internal/observable/race.ts 1 95.0%
src/internal/operators/throwIfEmpty.ts 1 93.94%
src/internal/observable/ConnectableObservable.ts 17 56.3%
Totals Coverage Status
Change from base Build 8207: -0.2%
Covered Lines: 5259
Relevant Lines: 5433
💛 - Coveralls

@dzhavat dzhavat mentioned this pull request Mar 17, 2019
Closed
5 tasks
niklas-wortmann
niklas-wortmann approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@niklas-wortmann niklas-wortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution!

@niklas-wortmann niklas-wortmann merged commit 2b1ebf8 into ReactiveX:master Mar 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklas-wortmann niklas-wortmann niklas-wortmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saxicek @coveralls @niklas-wortmann