feat(forkJoin): accepts a dictionary of sources #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
force-pushed
the
forkJoin-object
branch
from
482d77c
to
eaa3bb2
Compare
Generated by 🚫 dangerJS |
Pull Request Test Coverage Report for Build 8383
💛 - Coveralls |
benlesh
added a commit
to benlesh/rxjs
that referenced
this pull request
Mar 15, 2019
This PR deprecates all `combineLatest` signatures except `combineLatest([a, b, c])`, in order to make `combineLatest` smaller in an upcoming version, and in order for `combineLatest` to ever accept a dictionary of observables (and emit a dictionary of values), these extra functionsignatures need to be deprecated ahead of time to signal their future removal. related ReactiveX#4640
cartant
reviewed
Mar 16, 2019
benlesh
added a commit
that referenced
this pull request
Mar 19, 2019
#4641) This PR deprecates all `combineLatest` signatures except `combineLatest([a, b, c])`, in order to make `combineLatest` smaller in an upcoming version, and in order for `combineLatest` to ever accept a dictionary of observables (and emit a dictionary of values), these extra functionsignatures need to be deprecated ahead of time to signal their future removal. related #4640
- Adds `forkJoin({ foo, bar })` such that it will return an `Observable<{ foo, bar }>` containing the values emitted from the sources held at the properties of the passed object.
- DEPRECATED: `forkJoin(a, b, c, d)` should no longer be used, rather, just pass an array such as `forkJoin([a, b, c, d])`.
benlesh
force-pushed
the
forkJoin-object
branch
from
35643ad
to
e82e6a4
Compare
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this pull request
May 15, 2019
ReactiveX#4641) This PR deprecates all `combineLatest` signatures except `combineLatest([a, b, c])`, in order to make `combineLatest` smaller in an upcoming version, and in order for `combineLatest` to ever accept a dictionary of observables (and emit a dictionary of values), these extra functionsignatures need to be deprecated ahead of time to signal their future removal. related ReactiveX#4640
BioPhoton
pushed a commit
to BioPhoton/rxjs
that referenced
this pull request
May 15, 2019
- Adds `forkJoin({ foo, bar })` such that it will return an `Observable<{ foo, bar }>` containing the values emitted from the sources held at the properties of the passed object.
- DEPRECATED: `forkJoin(a, b, c, d)` should no longer be used, rather, just pass an array such as `forkJoin([a, b, c, d])`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forkJoin({ foo, bar })such that it will return anObservable<{ foo, bar }>containing the values emitted from the sources held at the properties of the passed object.forkJoin(a, b, c, d)should no longer be used, rather, just pass an array such asforkJoin([a, b, c, d]).Been wanting to do this one for a while. Going to try to get
combineLatestalso. (Inspired to get to it by @cartant ❤️)