Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pluck): fix pluck's catch-all signature for better type safety #5192

Merged
merged 3 commits into from
Jan 20, 2020
Merged

fix(pluck): fix pluck's catch-all signature for better type safety #5192

merged 3 commits into from
Jan 20, 2020

Commits on Dec 23, 2019

  1. fix(pluck): fix pluck's catch-all signature for better type safety 

    Change pluck's catch-all signature that is causing troubles when the
passed string is not a key in the argument object.

Issue: #5188
    @Lonelind
    Lonelind committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    5688e1e View commit details
    Browse the repository at this point in the history

  2. fix(pluck): fix signature and tests 

    Correct the signtaure to be accepted by tests and to return unknown in
general
    @Lonelind
    Lonelind committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    08c556c View commit details
    Browse the repository at this point in the history

  3. fix(pluck): add test case to check type inference

    @Lonelind
    Lonelind committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    6bfe635 View commit details
    Browse the repository at this point in the history