Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timeout): allow synchronous observable as source #5747

Merged
merged 1 commit into from Sep 23, 2020
Merged

fix(timeout): allow synchronous observable as source #5747

merged 1 commit into from Sep 23, 2020

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Sep 23, 2020

let synchronous subscription do not try to unsubscribe from not yet assigned timer subscription.

Description:

Related issue (if exists):

cartant
cartant approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwonoj kwonoj merged commit 40e7de5 into ReactiveX:master Sep 23, 2020
@kwonoj kwonoj deleted the timeout-sync-observable-fix branch September 23, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timeout() throws exception when source is synchronous
2 participants
@kwonoj @cartant