Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fromEvent): fixed HasEventTargetAddRemove to support EventTarget types #5945

Merged
merged 1 commit into from
Jan 3, 2021
Merged

fix(fromEvent): fixed HasEventTargetAddRemove to support EventTarget types #5945

merged 1 commit into from
Jan 3, 2021

Conversation

rraziel
Copy link
Contributor

@rraziel rraziel commented Dec 29, 2020

Description:

Makes it possible to use fromEvent() with a simple EventTarget.

Related issue (if exists):

Closes #5944

cartant
cartant approved these changes Dec 31, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@benlesh benlesh merged commit 5f022d7 into ReactiveX:master Jan 3, 2021
@benlesh
Copy link
Member

benlesh commented Jan 3, 2021

Thanks, @rraziel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlesh benlesh benlesh approved these changes

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fromEvent / FromEventTarget signatures don't work with basic event targets
3 participants
@rraziel @benlesh @cartant