Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(skipUntil): convert skipUntil tests to run mode #6221

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

tmair
Copy link
Contributor

@tmair tmair commented Apr 11, 2021

Description:
This PR updates skipUntil tests to run mode and updates one deprecated subscribe signature.

Related issue (if exists):
None

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small misalignment, AFAICT. Thanks.

spec/operators/skipUntil-spec.ts Outdated Show resolved Hide resolved
@cartant cartant merged commit 5d0552b into ReactiveX:master Apr 12, 2021
@tmair tmair deleted the skipUntil-run-mode branch April 12, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants