Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention jasmine.clock().mockDate() re: debounceTime #6386

Merged
merged 1 commit into from
May 10, 2021

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented May 8, 2021

Description:

This PR adds mention of jasmine.clock().mockDate() to the v6/v7 changes doc. Mostly 'cause Jasmine is so widely used in the Angular community, 'cause it does not mock Date.now() by default and 'cause debounceTime is a frequently-used operator.

It's not really a breaking change, but if people's tests suddenly fail - 'cause Jasmine is ... Jasmine - it might as well be.

馃が

Related issue (if exists): #6382

@cartant cartant requested a review from benlesh May 8, 2021 08:06
@cartant cartant added the 7.x Issues and PRs for version 6.x label May 8, 2021
@benlesh benlesh merged commit e0b5acb into ReactiveX:master May 10, 2021
@benlesh
Copy link
Member

benlesh commented May 10, 2021

Good call!

@cartant cartant deleted the cartant/debounce-time-v7 branch May 15, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x Issues and PRs for version 6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants