Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Subscription): idempotent add and remove of teardowns #6401

Merged
merged 2 commits into from
Sep 19, 2021

Commits on May 12, 2021

  1. feat(Subscription): idempotent add and remove of teardowns

    - Adding the same instance of a teardown more than once is the same as adding it once
    - Removing a teardown with `Subscription.prototype.remove` will remove it much faster
    
    BREAKING CHANGE: Adding the same function instance to a subscription as a teardown multiple times will now result in that function being executed only once on teardown. This brings us inline with the behavior of EventTarget, and also makes removing teardowns faster. The workaround is to make sure you are adding a new function instance to the Subscription each time if you need the same effect.
    
    Resolves ReactiveX#6400
    benlesh committed May 12, 2021
    Configuration menu
    Copy the full SHA
    6c79ef4 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Configuration menu
    Copy the full SHA
    2f5944a View commit details
    Browse the repository at this point in the history