Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(operators): clarify that find can emit undefined #6538

Merged
merged 1 commit into from Aug 5, 2021

Conversation

lazarljubenovic
Copy link
Contributor

Description: Was bitten by this; I expected no emission to happen if nothing is found. Thought it would be good to explicitly state the edge case in the docs, since just “it won't throw” don't really say anything about what will happen instead (nothing vs emits undefined).

@voliva
Copy link
Contributor

voliva commented Jul 27, 2021

Note that the commit message (and PR title) is wrong - it's referencing filter, but the operator docs that's fixing is find.

@lazarljubenovic lazarljubenovic changed the title docs(operators): clarify that filter can emit undefined docs(operators): clarify that find can emit undefined Jul 27, 2021
@lazarljubenovic
Copy link
Contributor Author

My bad, was trying to multitask too much 😄 It should be easy for the merger to change the filter to find from the commit message in GitHub UI (easier than me pulling and amending).

@benlesh benlesh merged commit f20a48a into ReactiveX:master Aug 5, 2021
@benlesh
Copy link
Member

benlesh commented Aug 5, 2021

Thank you @lazarljubenovic

@lazarljubenovic lazarljubenovic deleted the patch-2 branch August 8, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants