Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing deprecated subscribe and tap calls #6740

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 7, 2022

This was fixed in an automated way using a fixer that was added to @cartant's eslint-plugin-rxjs. Note that some of our test files weren't using prettier yet, so they're not formatted properly. That's okay. What I want to do is get these things updated so I can remove the deprecated call patterns for tap and subscribe in the 8.x branch and keep everything in sync.

@benlesh benlesh added 7.x 8.x labels Jan 7, 2022
@benlesh benlesh requested a review from cartant Jan 7, 2022
cartant
cartant approved these changes Jan 8, 2022
@benlesh benlesh merged commit c0ed6c5 into ReactiveX:master Jan 11, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7.x 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants