Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update docs app to Angular 13 #6743

Merged
merged 1 commit into from
Jan 14, 2022
Merged

chore: update docs app to Angular 13 #6743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions docs_app/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
!.vscode/extensions.json

# misc
/.angular/cache
/.sass-cache
/connect.lock
/coverage
Expand Down
19 changes: 0 additions & 19 deletions docs_app/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,16 +198,6 @@
}
]
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"src/tsconfig.app.json",
"src/tsconfig.spec.json"
],
"exclude": []
}
Comment on lines -203 to -210
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is precisely related to "@angular-devkit/build-angular": "~13.1.2", package. you can still upgrade to angular 13 and not upgrade @angular-devkit/build-angular (stay in v12). this way you can put back the lint. and probably we can address the linting and the afore-mentioned package upgrade after #6744 is done. wdyt ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'd rather keep everything in one PR - it's easier to maintain and to keep track. So, I'd rather keep this removed and reintroduced later, if this is OK to you?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep this removed

I will leave that to the gatekeepers of this library here.

IMHO, I wouldn't remove linting since we open the possibility of code that goes against our linting rules (without people being aware). So, I'd rather migrate to eslint in this PR. or do no upgrade @angular-devkit/build-angular to 13 until linting is figured out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest, temporarily disabling linting in the docs app is probably one of my last concerns. But I'll bring it up at the Core Team meeting.

}
}
},
Expand All @@ -222,15 +212,6 @@
"protractorConfig": "tests/e2e/protractor.conf.js",
"devServerTarget": "site:serve"
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"tests/e2e/tsconfig.e2e.json"
],
"exclude": []
}
}
}
}
Expand Down