Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindNodeCallback): convert bindNodeCallback specs to run mode #6957

Merged
merged 1 commit into from Sep 25, 2022
Merged

chore(bindNodeCallback): convert bindNodeCallback specs to run mode #6957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
189 changes: 111 additions & 78 deletions spec/observables/bindNodeCallback-spec.ts
View file
Open in desktop
@@ -1,12 +1,18 @@
/** @prettier */
import { expect } from 'chai';
import * as sinon from 'sinon';
import { bindNodeCallback } from 'rxjs';
import { TestScheduler } from 'rxjs/testing';

declare const rxTestScheduler: TestScheduler;
import { observableMatcher } from '../helpers/observableMatcher';

/** @test {bindNodeCallback} */
describe('bindNodeCallback', () => {
let rxTestScheduler: TestScheduler;

beforeEach(() => {
rxTestScheduler = new TestScheduler(observableMatcher);
});

describe('when not scheduled', () => {
it('should emit undefined when callback is called without success arguments', () => {
function callback(cb: Function) {
Expand All @@ -16,12 +22,14 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback);
const results: Array<number | string> = [];

boundCallback()
.subscribe({ next: (x: any) => {
boundCallback().subscribe({
next: (x: any) => {
results.push(typeof x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

expect(results).to.deep.equal(['undefined', 'done']);
});
Expand All @@ -34,12 +42,14 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback, (x: number) => x + 1);
const results: Array<number | string> = [];

boundCallback()
.subscribe({ next: x => {
boundCallback().subscribe({
next: (x) => {
results.push(x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

expect(results).to.deep.equal([43, 'done']);
});
Expand All @@ -51,12 +61,14 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback);
const results: Array<number | string> = [];

boundCallback(42)
.subscribe({ next: x => {
boundCallback(42).subscribe({
next: (x) => {
results.push(x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

expect(results).to.deep.equal([42, 'done']);
});
Expand All @@ -68,10 +80,7 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback);
const results: Array<number | string> = [];

boundCallback.call({datum: 42})
.subscribe(
{ next: (x: number) => results.push(x), complete: () => results.push('done') }
);
boundCallback.call({ datum: 42 }).subscribe({ next: (x: number) => results.push(x), complete: () => results.push('done') });

expect(results).to.deep.equal([42, 'done']);
});
Expand All @@ -86,14 +95,17 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback);
const results: Array<number | string> = [];

boundCallback()
.subscribe({ next: () => {
boundCallback().subscribe({
next: () => {
throw new Error('should not next');
}, error: (err: any) => {
},
error: (err: any) => {
results.push(err);
}, complete: () => {
},
complete: () => {
throw new Error('should not complete');
} });
},
});

expect(results).to.deep.equal([error]);
});
Expand All @@ -109,8 +121,7 @@ describe('bindNodeCallback', () => {
cb(null, datum);
}, 0);
}
const subscription = bindNodeCallback(callback)(42)
.subscribe({ next: nextSpy, error: throwSpy, complete: completeSpy });
const subscription = bindNodeCallback(callback)(42).subscribe({ next: nextSpy, error: throwSpy, complete: completeSpy });
subscription.unsubscribe();

setTimeout(() => {
Expand All @@ -130,18 +141,22 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback);
const results: Array<number | string> = [];

boundCallback(42)
.subscribe({ next: x => {
boundCallback(42).subscribe({
next: (x) => {
results.push(x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
boundCallback(54)
.subscribe({ next: x => {
},
});
boundCallback(54).subscribe({
next: (x) => {
results.push(x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

expect(results).to.deep.equal([42, 'done', 54, 'done']);
});
Expand All @@ -156,12 +171,14 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback, rxTestScheduler);
const results: Array<number | string> = [];

boundCallback()
.subscribe({ next: (x: any) => {
boundCallback().subscribe({
next: (x: any) => {
results.push(typeof x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

rxTestScheduler.flush();

Expand All @@ -175,12 +192,14 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback, rxTestScheduler);
const results: Array<number | string> = [];

boundCallback(42)
.subscribe({ next: x => {
boundCallback(42).subscribe({
next: (x) => {
results.push(x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

rxTestScheduler.flush();

Expand All @@ -194,10 +213,7 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback, rxTestScheduler);
const results: Array<number | string> = [];

boundCallback.call({datum: 42})
.subscribe(
{ next: (x: number) => results.push(x), complete: () => results.push('done') }
);
boundCallback.call({ datum: 42 }).subscribe({ next: (x: number) => results.push(x), complete: () => results.push('done') });

rxTestScheduler.flush();

Expand All @@ -211,14 +227,17 @@ describe('bindNodeCallback', () => {
}
const boundCallback = bindNodeCallback(callback, rxTestScheduler);

boundCallback(42)
.subscribe({ next: x => {
boundCallback(42).subscribe({
next: (x) => {
throw new Error('should not next');
}, error: (err: any) => {
},
error: (err: any) => {
expect(err).to.equal(expected);
}, complete: () => {
},
complete: () => {
throw new Error('should not complete');
} });
},
});

rxTestScheduler.flush();
});
Expand All @@ -233,14 +252,17 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback, rxTestScheduler);
const results: Array<number | string> = [];

boundCallback()
.subscribe({ next: () => {
boundCallback().subscribe({
next: () => {
throw new Error('should not next');
}, error: (err: any) => {
},
error: (err: any) => {
results.push(err);
}, complete: () => {
},
complete: () => {
throw new Error('should not complete');
} });
},
});

rxTestScheduler.flush();

Expand All @@ -255,12 +277,14 @@ describe('bindNodeCallback', () => {
const boundCallback = bindNodeCallback(callback, rxTestScheduler);
const results: Array<number[] | string> = [];

boundCallback(42)
.subscribe({ next: x => {
boundCallback(42).subscribe({
next: (x) => {
results.push(x);
}, complete: () => {
},
complete: () => {
results.push('done');
} });
},
});

rxTestScheduler.flush();

Expand All @@ -279,17 +303,23 @@ describe('bindNodeCallback', () => {

const source = boundCallback(42);

source.subscribe({ next: x => {
results1.push(x);
}, complete: () => {
results1.push('done');
} });
source.subscribe({
next: (x) => {
results1.push(x);
},
complete: () => {
results1.push('done');
},
});

source.subscribe({ next: x => {
results2.push(x);
}, complete: () => {
results2.push('done');
} });
source.subscribe({
next: (x) => {
results2.push(x);
},
complete: () => {
results2.push('done');
},
});

rxTestScheduler.flush();

Expand All @@ -305,7 +335,7 @@ describe('bindNodeCallback', () => {
}
let receivedError: any;
bindNodeCallback(badFunction)().subscribe({
error: err => receivedError = err
error: (err) => (receivedError = err),
});

expect(receivedError).to.equal('kaboom');
Expand All @@ -326,8 +356,8 @@ describe('bindNodeCallback', () => {

let result1: any;
let result2: any;
source$.subscribe(value => result1 = value);
source$.subscribe(value => result2 = value);
source$.subscribe((value) => (result1 = value));
source$.subscribe((value) => (result2 = value));

expect(calls).to.equal(1);
executeCallback(null, 'test');
Expand All @@ -343,15 +373,18 @@ describe('bindNodeCallback', () => {
cb(null, datum);
}
const boundCallback = bindNodeCallback(callback, rxTestScheduler);
const results1: Array<number|string> = [];
const results1: Array<number | string> = [];

const source = boundCallback(42);

const subscription = source.subscribe({ next: (x: any) => {
results1.push(x);
}, complete: () => {
results1.push('done');
} });
const subscription = source.subscribe({
next: (x: any) => {
results1.push(x);
},
complete: () => {
results1.push('done');
},
});

subscription.unsubscribe();

Expand Down