Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tagging to the big three models #761

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Added tagging to the big three models #761

wants to merge 6 commits into from

Conversation

kgf
Copy link
Member

@kgf kgf commented Oct 31, 2019

Person, event and item.

@kgf kgf changed the title Added to the big three models Added tagging to the big three models Oct 31, 2019
@gasparyn
Copy link

gasparyn commented Nov 4, 2019

can we add 3 small unit tests for each model that is now :taggable?
Mostly to make sure that they are actually acting as taggable

@houhoulis
Copy link
Collaborator

I agree with @gasparyn. Simple tests would suffice. I see the benefits as

  1. ensuring taggable is configured & working.
  2. documenting the use of taggable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kgf @gasparyn @houhoulis