Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made images in html exports use relative paths #152

Merged

Conversation

mxswd
Copy link
Contributor

@mxswd mxswd commented Aug 6, 2023

The image src tags were using filesystem absolute paths. I have changed it to use relative paths, so if you move the output directory to another place on the filesystem the html files still reference the same images.

I've only tested this exactly once.

@ReagentX
Copy link
Owner

ReagentX commented Aug 6, 2023

What is stripe_prefix()?

@mxswd
Copy link
Contributor Author

mxswd commented Aug 7, 2023

What is stripe_prefix()?

That was a mistake...

I've corrected that, and added a fallback if for some reason the path isn't absolute.

@ReagentX ReagentX changed the base branch from develop to feat/cs/use-local-paths September 3, 2023 19:14
@ReagentX ReagentX merged commit 129273f into ReagentX:feat/cs/use-local-paths Sep 3, 2023
@ReagentX ReagentX mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants