Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a test suite with integration and unit tests #46

Merged
merged 8 commits into from Dec 17, 2022

Conversation

ankurnarkhede
Copy link
Contributor

Created a test suite with unit and integration tests

Closes #42

@ankurnarkhede ankurnarkhede self-assigned this Dec 9, 2022
@ankurnarkhede ankurnarkhede marked this pull request as draft December 9, 2022 03:30
@yesyash
Copy link
Collaborator

yesyash commented Dec 9, 2022

Can you please add type: module in package.json, this would also require changes to be made in tsconfig.
Here is a link to the TS docs that can help: ECMAScript modules in Node.js

@ankurnarkhede ankurnarkhede marked this pull request as ready for review December 14, 2022 03:34
@ankurnarkhede ankurnarkhede changed the title Created a test suite with unit and integration tests Created a test suite with integration tests Dec 14, 2022
@ankurnarkhede ankurnarkhede changed the title Created a test suite with integration tests Created a test suite with integration and unit tests Dec 14, 2022
@ankurnarkhede
Copy link
Contributor Author

type: module

Tried this change, getting the error

app.ts(3,28): error TS2792: Cannot find module './middlewares'. Did you mean to set the 'moduleResolution' option to 'node', or to add aliases to the 'paths' option?

which requires all module imports to be explicitly imported with .js extension. Any idea around this?

Or can we merge the changes in the current PR first if the type module changes are not a blocker?
@yesyash

@ankurnarkhede
Copy link
Contributor Author

Can you please add type: module in package.json, this would also require changes to be made in tsconfig. Here is a link to the TS docs that can help: ECMAScript modules in Node.js

Adding an another PR for this.

@ankurnarkhede ankurnarkhede merged commit 82f88a2 into develop Dec 17, 2022
@ankurnarkhede ankurnarkhede deleted the feature/calendar-api branch December 17, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests setup in backend
2 participants