Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added entity-relationships and repositories #19

Merged
merged 5 commits into from Aug 31, 2023
Merged

added entity-relationships and repositories #19

merged 5 commits into from Aug 31, 2023

Conversation

DashDeipayan
Copy link
Contributor

@DashDeipayan DashDeipayan self-assigned this Aug 25, 2023
@DashDeipayan DashDeipayan linked an issue Aug 25, 2023 that may be closed by this pull request
Entity and relationships with JPA #15
Closed
bhtibrewal
bhtibrewal reviewed Aug 27, 2023
View reviewed changes
Copy link
Member

@bhtibrewal bhtibrewal left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the schema doc link in the description

iamitprakash
iamitprakash reviewed Aug 27, 2023
View reviewed changes
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add design doc

skill-tree /src/main/java/com/RDS/skilltree/EndorsementList/EndorsementListModel.java Outdated
@Column(name = "type", nullable = false)
private EndorsementType type;

@Column(name = "created_at", nullable = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about created_by, modified_by/_at

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't mentioned in the ER diagram

@DashDeipayan DashDeipayan merged commit ffdf66b into develop Aug 31, 2023
@DashDeipayan DashDeipayan deleted the jpa-entity-rel branch August 31, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhtibrewal bhtibrewal bhtibrewal left review comments

@vikhyat187 vikhyat187 vikhyat187 left review comments

@iamitprakash iamitprakash iamitprakash approved these changes

@Aanchal-Tiwari Aanchal-Tiwari Aanchal-Tiwari approved these changes

Assignees

@DashDeipayan DashDeipayan

Labels
None yet
Projects
Skill tree
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entity and relationships with JPA
5 participants
@DashDeipayan @iamitprakash @bhtibrewal @vikhyat187 @Aanchal-Tiwari