Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update count key in the response #171

Merged
merged 1 commit into from Nov 27, 2023
Merged

update count key in the response #171

merged 1 commit into from Nov 27, 2023

Conversation

sumitd94
Copy link
Contributor

Date: 27/11/2023

Developer Name: @sumitd94


Issue Ticket Number

Description

the count key in the response was returning the total number of counts the user has used for purging the cache, but ideally it should be giving us the remaining count the user has left with in purging cache

Documentation Updated?

  • Yes
  • No

If your feature adds a new API, then documentation related to the feature like API-Contracts, and Data-models must be updated.

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment.

Under Feature Flag

  • Yes
  • No

Specify if the changes are currently under a feature flag.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

Attach any relevant screenshots, such as test coverage reports, before and after images, or other visual aids.

Test Coverage

Provide information on the test coverage for the changes made in this PR. Include details on the types of tests conducted and their outcomes.

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

@prakashchoudhary07 prakashchoudhary07 merged commit 142116a into main Nov 27, 2023
@prakashchoudhary07 prakashchoudhary07 deleted the fix/count-key branch November 27, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants