Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges api contracts #29

Merged
merged 4 commits into from Apr 11, 2021
Merged

Badges api contracts #29

merged 4 commits into from Apr 11, 2021

Conversation

whyDontI
Copy link
Contributor

@whyDontI whyDontI commented Feb 7, 2021

Proposing API contracts for /badges API to be used in the members profile page

badges/README.md Outdated
rds-session: `<JWT>`
- **Body** `{ <badge_object> }`
- **Success Response:**
- **Code:** 204
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldnt be any body with 204.

badges/README.md Outdated
- **Headers**
Content-Type: application/json
- **Cookie**
rds-session: `<JWT>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to allow users to create custom new badge? 🤔

Copy link
Contributor

@sumitd94 sumitd94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Contract :)

@sumitd94 sumitd94 merged commit c8e6118 into main Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants