pagination capability for PRs API #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swarajpure
suggested changes
Jan 6, 2021
|
fixed the build errors |
swarajpure
suggested changes
Jan 6, 2021
|
fixed the page number to be 1 by default |
swarajpure
suggested changes
Jan 6, 2021
Comment on lines
110
to
115
| const { data } = await githubService.fetchOpenPRs() | ||
| let pageNumber = 1 | ||
|
|
||
| if (req.query.page > 1) { | ||
| pageNumber = req.query.page | ||
| } | ||
| const { data } = await githubService.fetchOpenPRs(pageNumber) |
There was a problem hiding this comment.
There is a better and short way to pass default arguments
Please have a look here:
website-backend/models/users.js
Line 60 in d17ea62
Also, please make sure to convert the argument to integer using parseInt as done in above function.
|
did the changes do check |
swarajpure
suggested changes
Jan 8, 2021
| @@ -107,7 +107,8 @@ const getStalePRs = async (req, res) => { | |||
| */ | |||
| const getOpenPRs = async (req, res) => { | |||
| try { | |||
| const { data } = await githubService.fetchOpenPRs() | |||
| const pageNumber = ((req.query.page) || 1) | |||
| const { data } = await githubService.fetchOpenPRs(pageNumber) | |||
There was a problem hiding this comment.
Can we simply pass it to the function than saving it in variable and then passing it?
fetchOpenPRs(req.query.page || 1) would be short and sweet
|
did the changes do check |
swarajpure
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the changes for getting the selected page value from user