Added /isUsernameAvailable/:username route in users main route #140

saishankarmanugula · 2021-01-24T06:28:19Z

Added route to check user availability. Added swagger definition and integration test for it.

ankurnarkhede · 2021-01-24T07:48:32Z

controllers/usersController.js

+    if (!result.userExists) {
+      return res.json({
+        message: 'User name Available',
+        userExists: result.userExists


Do we need to return the data of the user with that username too? 🤔

we are not returning data of user.it will return boolean false. Shall I remove 'userExists' Property and return only message in case of success?

ankurnarkhede · 2021-01-24T07:50:30Z

utils/swaggerDefinition.js

@@ -248,6 +248,14 @@ const swaggerOptions = {
            }
          }
        },
+        userAvailable: {
+          type: 'object',
+          properties: {


Conflicts with the actual response sent by the route.
Is there any contract written for this API?
What is the expected response?

Nikhylbat · 2021-01-26T12:55:21Z

controllers/usersController.js

+        userExists: result.userExists
+      })
+    }
+    return res.boom.notFound('User name not Available')


Any update on this? As per discussed in the meeting, we were to send a 200 with userExists as false.

Nikhylbat · 2021-01-26T12:57:02Z

controllers/usersController.js

+        userExists: result.userExists
+      })
+    }
+    return res.boom.notFound('User name not Available')


Any update on this? As per discussed in the meeting, we were to send a 200 with userExists as false.

…ackend into develop

swarajpure

Requesting some changes. Please check

swarajpure · 2021-03-04T12:35:42Z

routes/users.js

+ *             schema:
+ *               $ref: '#/components/schemas/errors/badImplementation'
+ */
+router.get('/isUsernameAvailable/:username', authenticate, usersController.checkUser)


Needs to be before /:username, right? 🤔

swarajpure · 2021-03-04T12:41:15Z

controllers/usersController.js

+  try {
+    const result = await userQuery.fetchUser({ username: req.params.username })
+    return res.json({
+      userAvailable: !result.userExists


Should be isUsernameAvailable as per API contracts

swarajpure · 2021-03-04T12:42:05Z

controllers/usersController.js

+    const result = await userQuery.fetchUser({ username: req.params.username })
+    return res.json({
+      userAvailable: !result.userExists
+    })


The case when the user is not logged in seems to be missing 🤔

swarajpure · 2021-03-04T12:42:42Z

controllers/usersController.js

@@ -48,6 +48,25 @@ const getUser = async (req, res) => {
  }
 }

+/**
+ * Checks whether a user exists or not


Should be something like checks whether a given username is available

swarajpure · 2021-03-04T12:43:10Z

controllers/usersController.js

+ * @param res {Object} - Express response object
+ */
+
+const checkUser = async (req, res) => {


The function name should also be changed accordingly

swarajpure · 2021-03-04T12:43:31Z

docs/swaggerDefinition.js

+        userAvailable: {
+          type: 'object',
+          properties: {
+            userAvailable: {


re: isUsernameAvailable

done. Changed the property name only to isUsernameAvailable.

saishankarmanugula · 2021-03-04T13:35:36Z

Please find below screenshots

The below one is without cookie.

swarajpure · 2021-03-04T17:14:45Z

test/integration/usersController.test.js

+        })
+    })
+
+    it('Should return userAvailable as false as we are passing existing user', function (done) {


NIT: username available

swarajpure

Looks good to me! 👌

Thank you for your patience with me 😂

Approving from my side

saishankarmanugula · 2021-03-04T17:31:24Z

Looks good to me! 👌

Thank you for your patience with me 😂

Approving from my side

Thanks for all the help swaraj

ankurnarkhede · 2021-03-04T18:15:06Z

routes/users.js

+ *             schema:
+ *               $ref: '#/components/schemas/errors/badImplementation'
+ */
+router.get('/isUsernameAvailable/:username', authenticate, usersController.getUsernameAvailabilty)


API schema yet to be added to the schema file for the new route.
https://github.com/Real-Dev-Squad/website-backend/blob/develop/README.md#api-documentation

Updated the schema file using npm run generate-api-schema. Please let me know if any further changes needs to be done

ankurnarkhede

LGTM ✅

saishankarmanugula@gmail.com added 2 commits January 24, 2021 11:44

added route to check user name availability

b418dcf

Merge branch 'issue123' into develop

cce18d3

saishankarmanugula requested a review from ankurnarkhede January 24, 2021 06:28

saishankarmanugula self-assigned this Jan 24, 2021

saishankarmanugula requested a review from swarajpure January 24, 2021 06:28

ankurnarkhede suggested changes Jan 24, 2021

View reviewed changes

Nikhylbat suggested changes Jan 26, 2021

View reviewed changes

saishankarmanugula@gmail.com added 2 commits January 28, 2021 11:29

added users/userAvailable/:id route

066a020

Merge branch 'issue123' into develop

e1292b4

saishankarmanugula requested a review from ankurnarkhede January 28, 2021 06:03

saishankarmanugula@gmail.com added 5 commits February 28, 2021 18:20

Merge branch 'develop' of https://github.com/Real-Dev-Squad/website-b…

d2235d3

…ackend into develop

updated code for users/isUsernameAvailable/username route

6e69bda

Merge branch 'issue123' into develop

e60e60c

changes for route users/isUsernameAvailable/username route

ad3d7fe

Merge branch 'develop' of https://github.com/Real-Dev-Squad/website-b…

94bd206

…ackend into develop

swarajpure suggested changes Mar 4, 2021

View reviewed changes

changes for routs users/isUsernameAvailble/username

a9dfc04

saishankarmanugula requested a review from swarajpure March 4, 2021 13:32

corrected review comments

7df518f

saishankarmanugula changed the title ~~Added /userAvailable/:username route in users main route~~ Added /isUsernameAvailable/:username route in users main route Mar 4, 2021

swarajpure reviewed Mar 4, 2021

View reviewed changes

corrected review comments

435de7f

swarajpure previously approved these changes Mar 4, 2021

View reviewed changes

ankurnarkhede suggested changes Mar 4, 2021

View reviewed changes

Corrected review changes related to api-schema

23f5d3f

saishankarmanugula dismissed swarajpure’s stale review via 23f5d3f March 5, 2021 09:40

saishankarmanugula requested a review from ankurnarkhede March 5, 2021 09:42

ankurnarkhede approved these changes Mar 5, 2021

View reviewed changes

ankurnarkhede merged commit bc46ea4 into Real-Dev-Squad:develop Mar 5, 2021

swarajpure linked an issue Mar 7, 2021 that may be closed by this pull request

Create an API to check if the username is already existing #123

Closed

iamitprakash mentioned this pull request Sep 15, 2023

Fetch User Details from Discord Id #1457

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added /isUsernameAvailable/:username route in users main route #140

Added /isUsernameAvailable/:username route in users main route #140

saishankarmanugula commented Jan 24, 2021

ankurnarkhede Jan 24, 2021

saishankarmanugula Jan 24, 2021

ankurnarkhede Jan 24, 2021

Nikhylbat Jan 26, 2021

Nikhylbat Jan 26, 2021

swarajpure left a comment

swarajpure Mar 4, 2021

saishankarmanugula Mar 4, 2021

swarajpure Mar 4, 2021

saishankarmanugula Mar 4, 2021

swarajpure Mar 4, 2021

swarajpure Mar 4, 2021

saishankarmanugula Mar 4, 2021

swarajpure Mar 4, 2021

saishankarmanugula Mar 4, 2021

swarajpure Mar 4, 2021

saishankarmanugula Mar 4, 2021

saishankarmanugula commented Mar 4, 2021 •

edited

swarajpure Mar 4, 2021 •

edited

swarajpure left a comment

saishankarmanugula commented Mar 4, 2021

ankurnarkhede Mar 4, 2021

saishankarmanugula Mar 5, 2021

ankurnarkhede left a comment

Added /isUsernameAvailable/:username route in users main route #140

Added /isUsernameAvailable/:username route in users main route #140

Conversation

saishankarmanugula commented Jan 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swarajpure left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saishankarmanugula commented Mar 4, 2021 • edited

swarajpure Mar 4, 2021 • edited

Choose a reason for hiding this comment

swarajpure left a comment

Choose a reason for hiding this comment

saishankarmanugula commented Mar 4, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankurnarkhede left a comment

Choose a reason for hiding this comment

saishankarmanugula commented Mar 4, 2021 •

edited

swarajpure Mar 4, 2021 •

edited