Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev to Main sync #1832

Merged
merged 13 commits into from
Jan 7, 2024
Merged

Dev to Main sync #1832

merged 13 commits into from
Jan 7, 2024

Conversation

Ajeyakrishna-k
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k commented Jan 5, 2024

Date: 5 January 2024

Developer Name: @Ajeyakrishna-k

‼️Please merge these together:


PR Numbers:-

Description:

Add description of the PR here

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

sahsisunny and others added 10 commits December 27, 2023 22:52
* ts-migration: convert some routes from js to ts

* ts-migration: goals, issues and index page

* ts-migration: convert healchecks, progresses, pullrequests, staging and trading in typescript

* fix: issue route import name

* fix: goals route import name

* change notify route js to ts
Co-authored-by: Joy <56365512+ardourApeX@users.noreply.github.com>
* feat: removes super user authorization for extension requests

* feat: removes super user test
* tempelate for all the pull requests raised in backend ( testing on forked branch )

* added disocrd new comer channelid in config for staging and prod
* fix: importing with file extension problem

* fix: remove logger import statements
router.post("/migrations", authenticate, authorizeRoles([SUPERUSER]), taskRequests.migrateTaskRequests);

// Deprecated | @Ajeyakrishna-k | https://github.com/Real-Dev-Squad/website-backend/issues/1597
router.post("/addOrUpdate", authenticate, validateUser, taskRequests.addOrUpdate);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
import goals from "../controllers/goals";
const router = express.Router();

router.get("/token", authenticate, goals.getGoalSiteToken);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
import { newTrade } from "../middlewares/validators/trading";
import { trade } from "../controllers/trading";

router.post("/stock/new/self", authenticate, newTrade, trade);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.

const router = express.Router();

router.patch("/user", validateUserRoles, authenticate, updateRoles);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.

router.post(
"/",
authenticate,

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
import { notifyController } from "../controllers/notify";
import { notifyValidator } from "../middlewares/validators/notify";

router.post("/", authenticate, notifyValidator, notifyController);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
getExtensionRequestsValidator,
extensionRequests.fetchExtensionRequests
);
router.get("/", authenticate, getExtensionRequestsValidator, extensionRequests.fetchExtensionRequests);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
This route handler performs
authorization
, but is not rate-limited.
@Ajeyakrishna-k
Copy link
Contributor Author

Screen.Recording.2024-01-05.at.7.58.00.PM.mov
Screenshot 2024-01-05 at 8 00 38 PM

@satyam73
Copy link
Member

satyam73 commented Jan 6, 2024

Everything working fine in staging

Validation also checked from my side, it's working fine👍

image

getting question when question is asked with post api
image
asking question with post request
image
super_user false sending unauth in response
image
initial connection with data: null

Ajeyakrishna-k and others added 3 commits January 6, 2024 15:47
* feat: if devMode do not do not redirect

* test: test case for auth dev=true flag

* chore: update title
@prakashchoudhary07
Copy link
Contributor

Redirection for incompelteUserDetails: true, if dev flag is passed, won't redirect to my.realdevsquad.com/signup page
image

image

@prakashchoudhary07 prakashchoudhary07 merged commit 58546d9 into main Jan 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants