Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing/Node version update #970

Merged
merged 8 commits into from
Apr 6, 2023
Merged

fixing/Node version update #970

merged 8 commits into from
Apr 6, 2023

Conversation

JAYATEJA04
Copy link
Contributor

@JAYATEJA04 JAYATEJA04 commented Mar 27, 2023

Issue no. #790

Now I can pass the integration and unit tests after changing the node-version from 14 to 18 in the package.json and test.yml files.

Things I tried to make it work

  • Changing ports
  • Updating the firebase CLI.
  • Installing firebase through npm.
  • Changing the host address in the firebase.json file. (worked✅)

Before changing the host address in the firebase.json file.

{
  "emulators": {
    "firestore": {
      "port": 8081
    },
    "ui": {
      "enabled": true,
      "port": 4000
    }
  }
}

After changing the host address in the firebase.json file

{
  "emulators": {
    "firestore": {
      "host": "0.0.0.0",
      "port": 8081
    },
    "ui": {
      "host": "0.0.0.0",
      "enabled": true,
      "port": 4000
    }
  }
}

Even the node-version has been updated in the test.yml file, and small changes in other files have also been done.

Reference

1.) #918
2.) firebase/firebase-tools#4741

@harshith-venkatesh
Copy link
Contributor

Are all API calls working as expected?

@JAYATEJA04
Copy link
Contributor Author

Are all API calls working as expected?

I'm not aware of how to check API calls, could you please tell me or give me a reference on how to check this one?

@JAYATEJA04
Copy link
Contributor Author

Are all API calls working as expected?

I'm not aware of how to check API calls, could you please tell me or give me a reference on how to check this one?

@harshith-venkatesh could you please let me know about this?

@harshith-venkatesh
Copy link
Contributor

Could that be checked via local database and postman?
@prakashchoudhary07 would you like to review this PR and add more points on the above please

@JAYATEJA04
Copy link
Contributor Author

Could that be checked via the local database and postman? @prakashchoudhary07 would you like to review this PR and add more points on the above, please

Hello @prakashchoudhary07, could you please let me know about this?

.eslintrc.js Outdated Show resolved Hide resolved
config/default.js Outdated Show resolved Hide resolved
firebase.json Outdated Show resolved Hide resolved
scripts/tests/tdd-files-list.txt Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@JAYATEJA04
Copy link
Contributor Author

@harshith-venkatesh @prakashchoudhary07
could you please look into this, I have tried to address the issues raised. Let me know if any other issues are to be addressed or if any changes are required to be done.

@JAYATEJA04
Copy link
Contributor Author

Hello @prakashchoudhary07
I have made the changes requested, few changes are the same as in the "develop" branch of the website-backend.

@JAYATEJA04
Copy link
Contributor Author

Regarding the change in port in the package.json file, I referred to these two:
1.) firebase/firebase-tools#4741 (comment) and
2.) #918

firebase.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
firebase.json Show resolved Hide resolved
scripts/tests/tdd-files-list.txt Outdated Show resolved Hide resolved
Copy link
Contributor Author

@JAYATEJA04 JAYATEJA04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited the necessary changes. Changed the port, fixed the formatting of the files and mentioned the reason behind mentioning host in package.json file.

.eslintrc.js Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
config/default.js Outdated Show resolved Hide resolved
firebase.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
firebase.json Show resolved Hide resolved
scripts/tests/tdd-files-list.txt Outdated Show resolved Hide resolved
firebase.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@prakashchoudhary07
Copy link
Contributor

Thanks for the PR

@prakashchoudhary07 prakashchoudhary07 merged commit 1c45b33 into Real-Dev-Squad:develop Apr 6, 2023
@heyrandhir heyrandhir mentioned this pull request Apr 7, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants