added CONTRIBUTING.md #32
Conversation
CONTRIBUTING.md
Outdated
| It may so happen that since the last time you cloned the repo/took a pull from develop, some changes may be merged in the develop branch. So to be on the safer side, we should have those changes as well. | ||
|
|
||
| In order to do that, we first checkout to **develop** branch by: | ||
|
|
||
| ``` | ||
| git checkout develop | ||
| ``` | ||
|
|
||
| Once we're in develop, it's time to take a pull: | ||
|
|
||
| ``` | ||
| git pull upstream develop | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Don't you think this section is getting repeated in pt. 4. Can we shorten it and make it more comprehensive in one point itself. What you think? or Is it really required.
There was a problem hiding this comment.
I just added it because, it was the samein every other repos as well. I think for a beginner not knowing this might create an issue, so let it be, this is what I think.
There was a problem hiding this comment.
Yeah i have noticed in other repos too . but won't it be better if you just provide a reference to point 4 instead of repeating the same. what you say?
for eg. Like repeat step 4
There was a problem hiding this comment.
Okay doing the change
priyanshk20
force-pushed
the
doc/contribute-guide
branch
from
89db4b4
to
3d4940b
Compare
CONTRIBUTING.md
Outdated
|
|
||
|  | ||
|
|
||
| 1. **Cloning repository** |
CONTRIBUTING.md
Outdated
| @@ -107,7 +97,7 @@ git rebase develop | |||
|
|
|||
| You should solve the merge conflicts, if any. | |||
|
|
|||
| 9. **Pushing your code** | |||
| 1. **Pushing your code** | |||
There was a problem hiding this comment.
Why did you make it 1? Where is point 9
There was a problem hiding this comment.
Oh my bad! Mistake in copy paste, will fix
Closes #31
Added a markdown file which gives details regarding making a Pull Request in goals site