Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seo meta tags for link preview #179

Merged
merged 1 commit into from Jun 17, 2021

Conversation

DashDeipayan
Copy link
Contributor

@sumitd94 @ankushdharkar Please review this PR

@DashDeipayan DashDeipayan added the good first issue Good for newcomers label Jun 10, 2021
@DashDeipayan DashDeipayan self-assigned this Jun 10, 2021
@@ -11,6 +11,9 @@ class MyDocument extends Document {
<Html>
<Head>
<meta charSet="UTF-8" />
<meta property="og:title" content="Members Page:RDS" />
<meta property="og:image" content="/images/Real-Dev-Squad@1x.png" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the RDS Logo? we do not want the RDS logo to be shown as Preview. @ankushdharkar has the preview image for members

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with my instincts haha...once the image is provided I can make the change easily

Copy link
Contributor

@sumitd94 sumitd94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@sumitd94 sumitd94 merged commit 6482041 into Real-Dev-Squad:develop Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants