Updated/Standardized navbar of member-site #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohan09-raj
suggested changes
Oct 21, 2021
rohan09-raj
suggested changes
Oct 21, 2021
rohan09-raj
reviewed
Oct 24, 2021
There was a problem hiding this comment.
@Kshashank99 In the mobile view, please add the link of status site also and if possible can you please left-align X a bit.
rohan09-raj
previously approved these changes
Oct 29, 2021
rohan09-raj
suggested changes
Oct 29, 2021
Removed comment
sumitd94
reviewed
Nov 5, 2021
sumitd94
reviewed
Nov 5, 2021
sumitd94
reviewed
Nov 5, 2021
swarajpure
reviewed
Nov 6, 2021
swarajpure
reviewed
Nov 6, 2021
swarajpure
reviewed
Nov 6, 2021
harshith-venkatesh
previously approved these changes
Nov 6, 2021
|
Hey @rohan09-raj, @sumitd94 and @harshith-venkatesh Please review the PR. After |
swarajpure
suggested changes
Jan 6, 2022
rohan09-raj
reviewed
Jan 6, 2022
There was a problem hiding this comment.
@Kshashank99 Can you please remove all the previous attached images in conversation and only upload the current updated UI screenshot in the description. It is bit confusing for us to understand which is the latest one.
Upload the following screenshots :
- Desktop View
- Mobile view (navbar menu closed)
- Mobile view (navbar menu open)
|
@rohan09-raj @sumitd94 @swarajpure Please review the PR #265 : Before:Desktop view
Mobile view
After:Desktop view
Mobile view
|
rohan09-raj
reviewed
Jan 11, 2022
rohan09-raj
suggested changes
Jan 18, 2022
src/components/UI/navbar/index.js
Outdated
| <li className={nav.name === 'Home' ? `${styles.Homes}` : null}> | ||
| <li | ||
| className={nav.name === 'Home' ? `${styles.homes}` : null} | ||
| key |
There was a problem hiding this comment.
Why this prop has no value ??
rohan09-raj
previously approved these changes
Jan 25, 2022
| setUserData({ | ||
| userName: responseJson.username, | ||
| firstName: responseJson.first_name, | ||
| profilePicture: responseJson.picture.url?.DEFAULT_AVATAR, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the changes as per the instructions. Please review my PR.
Updated Navbar :
Closes #261