Tasks refactor #208

swarajpure · 2022-02-01T18:58:30Z

New task statuses should be visible in sidebar
New task statuses should be selectable in a dropdown for a task, such that task status can be changed by clicking the dropdown
Message in case of no tasks being found
Refactor logic for filtering tasks according to task type
Refactor logic after API call to update a task
Add loader and response after updating a task
Add ALL tasks in the sidebar such that we support and show the tasks with older task statuses

…idebar

swarajpure · 2022-02-06T20:06:49Z

All tasks is shown by default. Notice that it contains current task status as well:

Assigned tasks view. Notice that the task slider isn't shown here:

In Progress tasks view. Notice that we're showing task slider here:

No task found message:

app/components/side-bar.hbs

ankushdharkar · 2022-02-07T02:37:10Z

app/components/task/holder.hbs

-        {{on "change" this.onPercentageChange}}
-        {{on "change" (fn @onTaskUpdate @task.id)}}
-      />
+  {{#if (eq @task.status 'IN_PROGRESS')}}


Can we use a known enum here please?

Didn't get this point, couldn't find anything useful on Googling for enum in ember or enum in handlebars
Can you please provide some resource for this one?

const STATUSES = { IN_PROGRESS: 'IN_PROGRESS', }

app/components/task/holder.hbs

app/components/task/holder.js

ankushdharkar · 2022-02-07T02:40:28Z

app/constants/tasks.js

-  COMPLETED: 'completed',
-  PENDING: 'pending',
-};
+const TASK_STATUSES = [


I wonder if this should be a map, instead of an array.

If I want to look up if there's a key called TASK_STATUSES.<keyname>, we have no easy way of doing it anymore. What do we benefit from making this an array here?

we're using this array to show the sidebar options, if we use map, the order would be messed up, right?

@swarajpure We can take the enum list, and make it into an array using Object.keys

My concern with using an object is, will we be able to ensure the order of the keys? If the order is messed up, the list will obtained from Object.keys will also have different order and the sidebar won't have predictable order. Someone might say "I remember In Progress was the third option last week, why and how is it changed now?" @ankushdharkar

@swarajpure Good point. So we can do something like this:

const DISPLAY_LIST = [ IN_PROGRESS, COMPLETED, UNASSIGNED ];

Why will this order change?

Made the change

app/controllers/tasks.js

ankushdharkar · 2022-02-07T02:43:50Z

app/controllers/tasks.js

    const cleanBody = this.cleanReqBody(taskData);
    if (taskData.status || taskData.percentCompleted) {
      try {
+        this.isLoading = true;
        const response = await fetch(`${API_BASE_URL}/tasks/self/${taskId}`, {


This should be moved in ember-data.

i agree but ember data isn't in place yet

Can you create a ticket or mention it for this issue please, so we start integrating it?

app/controllers/tasks.js

app/styles/tasks.css

ankushdharkar · 2022-02-07T02:45:39Z

tests/integration/components/tasks-test.js

@@ -12,7 +12,7 @@ module('Integration | Component | tasks', function (hooks) {



Do we need more tests to cover the new feature(s)?

yes, we definitely need tests, there are no tests as of now, since this feature had a tight deadline

@swarajpure Then let's please have a ticket that tracks the follow-up of tests with timeline/ETA

swarajpure · 2022-02-07T20:38:53Z

Normal view:

In case of hovering over any task status:

swarajpure · 2022-02-07T20:42:15Z

app/components/task/holder.hbs

@@ -1,16 +1,44 @@
-<div class="task-card">
+<div class="task-card" tabindex="0">


added tabindex so each task card can be highlighted when traversing via keyboard

Pavangbhat

Hi @swarajpure
Are we using /tasks/self endpoint to get all the tasks, if yes we cannot make use of it since it does not return all the tasks
Checkout this 👇
https://github.com/Real-Dev-Squad/website-api-contracts/tree/main/tasks#get-tasksself

we can make use of /tasks/username 👇
https://github.com/Real-Dev-Squad/website-api-contracts/tree/main/tasks#get-tasksusername

RESOLVED ⬆️

config/environment.js

swarajpure self-assigned this Feb 1, 2022

swarajpure linked an issue Feb 5, 2022 that may be closed by this pull request

Update my-site to handle New Task Workflow #198

Closed

4 tasks

swarajpure added 4 commits February 6, 2022 20:58

feat: change task statuses to new ones

2cad7eb

chore: add network call on changing status

b309184

chore: refactor logic to display tasks and add new task statuses to s…

c889c28

…idebar

chore: refactor logic for re-adjusting tasks after PATCH API call

40369f8

swarajpure force-pushed the feat/tasks-revamp branch from 45225b2 to 40369f8 Compare February 6, 2022 16:22

swarajpure marked this pull request as ready for review February 6, 2022 16:24

This was linked to issues Feb 6, 2022

Should show a message if there are no tasks in particular category #85

Closed

Show some notification after Updating a task #170

Closed

swarajpure changed the title ~~Change task statuses to new ones~~ Tasks refactor Feb 6, 2022

chore: add support for seeing all tasks

62a8e5f

swarajpure force-pushed the feat/tasks-revamp branch from 325df39 to 62a8e5f Compare February 6, 2022 19:33

chore: tests pass

5507235

swarajpure requested review from akankshadharkar, ankushdharkar and prakashchoudhary07 February 6, 2022 20:42

ankushdharkar requested changes Feb 7, 2022

View reviewed changes

swarajpure added 3 commits February 8, 2022 00:39

chore: new style for tasks sidebar

449769a

chore: moving variables for better readability

b57839f

chore: follow BEM convention

24c59c5

chore: better variable names

844aac5

swarajpure commented Feb 7, 2022

View reviewed changes

Pavangbhat reviewed Feb 8, 2022

View reviewed changes

swarajpure added 3 commits February 24, 2022 01:05

chore: not allow task status change if status is VERIFIED

b7ad09d

chore: add endsOn in case of VERIFIED tasks

999f33d

chore: move away from direct use of strings for task status

396a2f0

swarajpure commented Mar 2, 2022

View reviewed changes

config/environment.js Outdated Show resolved Hide resolved

prakashchoudhary07 and others added 3 commits March 10, 2022 21:37

chore: revert BASE_API_URL

e05c5a9

removed endsOn for VERIFIED PATCH request(handled from backend)

4792332

Fix: typo

1f32b43

Pavangbhat merged commit b8fcdbc into develop Apr 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tasks refactor #208

Tasks refactor #208

swarajpure commented Feb 1, 2022 •

edited

swarajpure commented Feb 6, 2022

ankushdharkar Feb 7, 2022

swarajpure Feb 7, 2022

ankushdharkar Feb 17, 2022

ankushdharkar Feb 7, 2022

swarajpure Feb 7, 2022

ankushdharkar Feb 12, 2022

swarajpure Feb 16, 2022

ankushdharkar Feb 17, 2022

swarajpure Feb 26, 2022

ankushdharkar Feb 7, 2022

swarajpure Feb 7, 2022

ankushdharkar Feb 12, 2022

swarajpure Feb 16, 2022

ankushdharkar Feb 7, 2022

swarajpure Feb 7, 2022

ankushdharkar Feb 12, 2022

swarajpure commented Feb 7, 2022

swarajpure Feb 7, 2022

Pavangbhat left a comment •

edited

		@@ -12,7 +12,7 @@ module('Integration \| Component \| tasks', function (hooks) {

		@@ -1,16 +1,44 @@
		<div class="task-card">
		<div class="task-card" tabindex="0">

Tasks refactor #208

Tasks refactor #208

Conversation

swarajpure commented Feb 1, 2022 • edited

swarajpure commented Feb 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swarajpure commented Feb 7, 2022

Choose a reason for hiding this comment

Pavangbhat left a comment • edited

Choose a reason for hiding this comment

swarajpure commented Feb 1, 2022 •

edited

Pavangbhat left a comment •

edited