generated from Real-Dev-Squad/website-template
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: New sign up flow #238
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankushdharkar
requested changes
Jul 16, 2022
ankushdharkar
requested changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cleanups suggested.
Closed
sumitd94
force-pushed
the
refactor/signup-flow
branch
from
August 14, 2022 10:03
981e6e4
to
6a1a4b8
Compare
ankushdharkar
requested changes
Aug 15, 2022
The Refactor is already implemented here #268 and is live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the refactoring of the new sign-up flow which is currently behind the feature flag.
Link to the ticket - #239
How to access the new sign-up flow?
To access the new sign-up flow, in the query param we will have to pass
dev=true
to the existing signup route -/signup?dev=true
This will redirect you to the new sign-up flow.
Currently, users are redirected to our sign-up page from the welcome site
Here we will have to pass the query param with
dev=true
so that the users will be able to access the new sign up flow.What is required to make this new sign-up flow live to the users
Currently, this feature is behind the feature flag. We will have to track and test how many users are actually able to sign up using our new flow.
One way to track this is by integrating mixpanel into the new flow which will help us in tracking the user's interaction with the new flow.
Once we have an adequate amount of data that proves that the users who are signing up using our new flow are successfully being signed up, we can remove this feature behind the feature and make it live.
Pending tasks on this PR