Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: New sign up flow #238

Closed
wants to merge 14 commits into from
Closed

Refactor: New sign up flow #238

wants to merge 14 commits into from

Conversation

sumitd94
Copy link
Contributor

@sumitd94 sumitd94 commented Jul 11, 2022

This PR includes the refactoring of the new sign-up flow which is currently behind the feature flag.

Link to the ticket - #239

How to access the new sign-up flow?

To access the new sign-up flow, in the query param we will have to pass dev=true to the existing signup route - /signup?dev=true
This will redirect you to the new sign-up flow.

Currently, users are redirected to our sign-up page from the welcome site
Here we will have to pass the query param with dev=true so that the users will be able to access the new sign up flow.

What is required to make this new sign-up flow live to the users

Currently, this feature is behind the feature flag. We will have to track and test how many users are actually able to sign up using our new flow.
One way to track this is by integrating mixpanel into the new flow which will help us in tracking the user's interaction with the new flow.

Once we have an adequate amount of data that proves that the users who are signing up using our new flow are successfully being signed up, we can remove this feature behind the feature and make it live.

Pending tasks on this PR

  • Create a Data flow diagram for the new-signup flow
  • Create a new PR with refactored button and form component
  • Add test cases for the components
  • Change the code in website welcome and website-www to redirect the users to this new sign-up flow
  • Create refactored tickets to move URLs to constanst

@sumitd94 sumitd94 self-assigned this Jul 11, 2022
@sumitd94 sumitd94 marked this pull request as draft July 11, 2022 16:19
@sumitd94 sumitd94 marked this pull request as ready for review July 15, 2022 17:05
app/controllers/signup.js Outdated Show resolved Hide resolved
@ankushdharkar ankushdharkar added the refactor Refactoring Code label Jul 16, 2022
Copy link
Contributor

@ankushdharkar ankushdharkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanups suggested.

app/components/new-sign-up/button.js Outdated Show resolved Hide resolved
app/components/new-sign-up/form.hbs Show resolved Hide resolved
app/components/new-sign-up/form.hbs Outdated Show resolved Hide resolved
app/controllers/new-signup.js Outdated Show resolved Hide resolved
app/controllers/new-signup.js Outdated Show resolved Hide resolved
app/templates/new-signup.hbs Outdated Show resolved Hide resolved
app/templates/signup.hbs Show resolved Hide resolved
app/templates/signup.hbs Show resolved Hide resolved
@ankushdharkar ankushdharkar mentioned this pull request Aug 6, 2022
app/components/new-sign-up/button.hbs Show resolved Hide resolved
app/components/new-sign-up/form.hbs Outdated Show resolved Hide resolved
app/components/new-sign-up/form.hbs Show resolved Hide resolved
app/components/new-sign-up/get-started.hbs Outdated Show resolved Hide resolved
app/components/new-sign-up/get-started.hbs Outdated Show resolved Hide resolved
app/controllers/signup.js Show resolved Hide resolved
app/controllers/signup.js Show resolved Hide resolved
app/routes/new-signup.js Show resolved Hide resolved
tests/unit/controllers/signup-test.js Show resolved Hide resolved
@sumitd94 sumitd94 marked this pull request as draft August 23, 2022 16:57
@rohan09-raj
Copy link
Contributor

rohan09-raj commented May 22, 2023

The Refactor is already implemented here #268 and is live

@rohan09-raj rohan09-raj deleted the refactor/signup-flow branch May 22, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants