Bug : Fixed UI & UX of filter modal #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ajoykumardas12
approved these changes
Nov 24, 2023
|
Can you add screenshots of code coverage of the file that you have changed. |
Done. Please check. |
Ajeyakrishna-k
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 996
Description:
escis pressed.Anything you would like to inform the reviewer about:
In the video, it may seem like the modal is closing while selecting an option from
1:11, but at that moment, I am actually pressing Escape.Dev Tested:
Under Feature Flag:
Frontend Changes:
Images/video of the change:
simplescreenrecorder-2023-11-21_23.04.54.mp4
Test Suits
Test Coverage