Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default status from Task Search #1024

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

joyguptaa
Copy link
Contributor

Issue: 996

Description:

  1. Task search should not show status:all in dev mode, as it won't make sense once we have suggestions.

Anything you would like to inform the reviewer about:

NA

Dev Tested:

  • Yes

Under Feature Flag:

  • Yes

Frontend Changes:

  • Yes

Images/video of the change:

simplescreenrecorder-2023-11-26_15.39.25.mp4

Test Suits

image

Test Coverage

image

Copy link

vercel bot commented Nov 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 7:03am

ajoykumardas12
ajoykumardas12 previously approved these changes Nov 26, 2023
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve after the comments are resolved.

@prakashchoudhary07 prakashchoudhary07 merged commit e621d48 into develop Nov 27, 2023
3 checks passed
@prakashchoudhary07 prakashchoudhary07 deleted the refactor/remove-default-status branch November 27, 2023 19:15
@joyguptaa joyguptaa mentioned this pull request Dec 3, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants