Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Added options for task search #1035

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Conversation

joyguptaa
Copy link
Contributor

@joyguptaa joyguptaa commented Dec 3, 2023

Issue: 996

Reference: #1033

Description:

Added functionality to display suggestions, if found, otherwise show no suggestion found

Dependent PR(s):

Checklist :

  1. Should render suggestion if typed input has more than 2 characters and has no key
  2.  Should render suggestion if typed input has more than 2 characters in value if key is present
  3. Should show no suggestion found if no suggestion is found

Anything you would like to inform the reviewer about:

NA

Dev Tested:

  • Yes

Under Feature Flag:

  • Yes

Frontend Changes:

  • Yes

Images/video of the change:

  • Should render suggestion if typed input has more than 2 characters and has no key
  •  Should render suggestion if typed input has more than 2 characters in value if key is present
Screen.Recording.2023-12-03.at.17.48.22.mov
  • Should show no suggestion found if no suggestion is found
Screen.Recording.2023-12-04.at.01.53.14.mov

Test Suits

Screenshot 2023-12-03 at 12 53 33 Screenshot 2023-12-03 at 12 55 16

Test Coverage

Screenshot 2023-12-03 at 12 59 20

Copy link

vercel bot commented Dec 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 4:36pm

@ajoykumardas12
Copy link
Contributor

Do we have active task status as indicated in placeholder?

@joyguptaa
Copy link
Contributor Author

joyguptaa commented Dec 4, 2023

d in placeholder?

It's not a valid status though but it is still there in the placeholder. I've update it here you can check

iamitprakash
iamitprakash previously approved these changes Dec 5, 2023
@iamitprakash iamitprakash merged commit cdda0ae into develop Dec 5, 2023
3 checks passed
@iamitprakash iamitprakash deleted the feat/task-search-options branch December 5, 2023 18:37
@joyguptaa joyguptaa mentioned this pull request Dec 7, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants