Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made new task search functional #1040

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

joyguptaa
Copy link
Contributor

@joyguptaa joyguptaa commented Dec 5, 2023

Issue: 996

Description:

  1. Enabled complete functionality of new task search
  2. Fixed filter modal positioning issue
  3. Enabled test cases for task search

Dev Tested:

  • Yes

Frontend Changes:

  • Yes

Under Feature Flag

  • Yes

Images/video of the change:

Screen.Recording.2023-12-06.at.00.30.39.mov

Test Coverage

Screenshot 2023-12-06 at 00 37 53

Test Cases

Screenshot 2023-12-06 at 00 46 21

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 5:04am

@heyrandhir
Copy link
Contributor

@ardourApeX In the demo video I observed that the color of the pill had transitioned from grey to red. Could you provide insights into the reason for this change

image

also observed that the entire screen reloads when a specific filter was selected. Is this behavior an existing issue or a result of your recent changes?

@joyguptaa
Copy link
Contributor Author

joyguptaa commented Dec 6, 2023

@ardourApeX In the demo video I observed that the color of the pill had transitioned from grey to red. Could you provide insights into the reason for this change

image

Yes, it is an expected behavior to highlight the pill just before deleting it.

also observed that the entire screen reloads when a specific filter is selected. Is this behavior an existing issue or a result of your recent changes?

Screen.Recording.2023-12-06.at.10.28.49.mov

As it is making an API call after selecting the filter, it has the refresh the bottom component where it renders all the tasks. And the same is happening if you check it on prod under the dev flag.

@sahsisunny sahsisunny merged commit 08fe186 into develop Dec 6, 2023
3 checks passed
@sahsisunny sahsisunny deleted the feat/task-serach-deploy branch December 6, 2023 07:04
@joyguptaa joyguptaa mentioned this pull request Dec 7, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants