Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made tooltip component reusable #1123

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Made tooltip component reusable #1123

merged 10 commits into from
Feb 19, 2024

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Feb 17, 2024 •
edited

Date: 17 feb 2024

Developer Name: @skv93-coder

Refrence

https://ant.design/components/tooltip

Issue Ticket Number

Description

Makes tooltip component more reuseable

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

screen-capture.7.webm
Screenshot 1

Test Coverage

Screenshot from 2024-02-17 23-51-21
Screenshot from 2024-02-18 00-15-30

Screenshot 1

Additional Notes

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 9:18am

@skv93-coder skv93-coder added the bug-hunt for bug hunt seesion label Feb 17, 2024
ajoykumardas12
ajoykumardas12 reviewed Feb 18, 2024
View reviewed changes
Copy link
Contributor

@ajoykumardas12 ajoykumardas12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me mostly but I got this issue when checking in my local, does it happen for you too?

2024-02-18.19-37-04.mp4

src/components/common/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
@skv93-coder
Copy link
Contributor Author

Looks good to me mostly but I got this issue when checking in my local, does it happen for you too?

2024-02-18.19-37-04.mp4

Looks good to me mostly but I got this issue when checking in my local, does it happen for you too?

2024-02-18.19-37-04.mp4

It was a mistake from my side. corrected good review.

satyam73
satyam73 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@satyam73 satyam73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyam73 satyam73 merged commit 4ff1353 into develop Feb 19, 2024
3 checks passed
@satyam73 satyam73 deleted the component/tooltip branch February 19, 2024 16:28
@skv93-coder skv93-coder mentioned this pull request Feb 25, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavangbhat Pavangbhat Pavangbhat left review comments

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

@satyam73 satyam73 satyam73 approved these changes

@ajoykumardas12 ajoykumardas12 ajoykumardas12 approved these changes

Assignees
No one assigned
Labels
bug-hunt for bug hunt seesion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@skv93-coder @Pavangbhat @Achintya-Chatterjee @satyam73 @ajoykumardas12