Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown editor with preview option for creating TCR #1176

Merged
merged 8 commits into from
Mar 17, 2024

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Mar 7, 2024

Date: 8th March 2024

Developer Name: Tushar Goel


Issue Ticket Number

#1162

Description

Replace the textbox with markdown and preview creating TCR

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Will update

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Screenshot from 2024-03-11 23-19-27
Screenshot from 2024-03-11 23-18-51

Test Coverage

Screenshot 1

Screenshot from 2024-03-17 18-14-20

Additional Notes

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link

vercel bot commented Mar 7, 2024

@TG1999 is attempting to deploy a commit to the RDS-Team Team on Vercel.

A member of the Team first needs to authorize it.

@TG1999 TG1999 marked this pull request as draft March 7, 2024 19:43
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 marked this pull request as ready for review March 11, 2024 17:50
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@prakashchoudhary07
Copy link
Contributor

Tests are failing please have a look, and also please update description of the PR

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Contributor Author

TG1999 commented Mar 16, 2024

@prakashchoudhary07 added description and tests are fixed now, please authorize the vercel for deployment, thanks!

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage stats

src/constants/FeatureFlags.ts Show resolved Hide resolved
TG1999 and others added 2 commits March 17, 2024 18:16
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@iamitprakash iamitprakash merged commit 83941c8 into Real-Dev-Squad:develop Mar 17, 2024
1 of 2 checks passed
@TG1999
Copy link
Contributor Author

TG1999 commented Mar 22, 2024

@yesyash

@TG1999 TG1999 mentioned this pull request Mar 25, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants