Use useFetch hook in tasks page #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/hooks/useFetch.ts
Outdated
| const [error, setError] = React.useState(null); | ||
| const [isLoading, setIsLoading] = React.useState(false); | ||
| React.useEffect(() => { | ||
| const useFetch = (url: string) => { |
There was a problem hiding this comment.
If this is a reusable utility, I think a way to provide options would be good to have. So it can be used for any type of usecase.
src/hooks/useFetch.ts
Outdated
| setIsLoading(false); | ||
| } catch (err) { | ||
| setIsLoading(false); |
There was a problem hiding this comment.
finally block will run regardless of the error not. So this is not needed here.
Cartmanishere
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64