REFACTOR: removed old see more button from TaskList components #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sahsisunny
changed the title
|
Can you look into improving test coverage here |
Apologies, but I'm currently unable to write tests for this component. Could you kindly assist me in improving test coverage? |
|
Could you please refer other test cases in project and try creating test cases, it seems like you have removed the scenarios, you could have tested by modifying them as well. |
|
I am unable to write the test for lines 23 to 24 of the |
|
Why are we closing the PR here |
|
sahsisunny
force-pushed
the
refactor/remove-unused-code
branch
from
f78297f
to
aba7110
Compare
Pratiyushkumar
previously approved these changes
Aug 29, 2023
sahsisunny
force-pushed
the
refactor/remove-unused-code
branch
from
fcf1df7
to
f7b7066
Compare
vinit717
approved these changes
Sep 19, 2023
Pratiyushkumar
approved these changes
Sep 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #773
Description:
In this PR, I removed the old see more button functionality from the TaskList components. This was done because the new Load More button functionality is now in place.
Anthing you would like to inform the reviewer about:
Also, fix the typo in the PR template.
Dev Tested:
Test Coverage