Multiple Assignee Tasks Search and TasksContent Component Refactor #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajoykumardas12 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
ajoykumardas12
changed the title
ajoykumardas12
changed the title
ajoykumardas12
changed the title
ajoykumardas12
requested review from
iamitprakash,
sahsisunny and
Pratiyushkumar
iamitprakash
approved these changes
Oct 7, 2023
kotesh-arya
approved these changes
Oct 7, 2023
Merged
iamitprakash
added a commit
that referenced
this pull request
Oct 9, 2023
* fix/issue-866: the status page UI issues breaking on tab sized and small sized laptop like 1024px and smaller mobile devices 280px as in galaxy fold have been fixed Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Fix: alignment of signup with github btn fixed Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Removed commented code Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Updated px to rem on card scss module Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Resolved merge conflicts on tasks/card comp Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * chore: updated media queries in rem to px in card css module as per Mahima's review Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Revert "Remove Feature Flag | Assign Issue (#908)" This reverts commit 2525682. * Multiple Assignee Tasks Search and TasksContent Component Refactor (#915) --------- Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> Co-authored-by: Aneena John Xavier <aneena_john_xavier@epam.com> Co-authored-by: Sunny Sahsi <sahsisunny@gmail.com> Co-authored-by: aneenajohn <75213145+aneenajohn@users.noreply.github.com> Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Ajoy Kumar Das <87164140+ajoykumardas12@users.noreply.github.com>
This was referenced Oct 10, 2023
iamitprakash
added a commit
that referenced
this pull request
Oct 14, 2023
…#938) * Dev to main Sync (#914) * fix/issue-866: the status page UI issues breaking on tab sized and small sized laptop like 1024px and smaller mobile devices 280px as in galaxy fold have been fixed Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Fix: alignment of signup with github btn fixed Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Removed commented code Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Updated px to rem on card scss module Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Resolved merge conflicts on tasks/card comp Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * chore: updated media queries in rem to px in card css module as per Mahima's review Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> * Revert "Remove Feature Flag | Assign Issue (#908)" This reverts commit 2525682. * Multiple Assignee Tasks Search and TasksContent Component Refactor (#915) --------- Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> Co-authored-by: Aneena John Xavier <aneena_john_xavier@epam.com> Co-authored-by: Sunny Sahsi <sahsisunny@gmail.com> Co-authored-by: aneenajohn <75213145+aneenajohn@users.noreply.github.com> Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Ajoy Kumar Das <87164140+ajoykumardas12@users.noreply.github.com> * When the title text doesnt fit, it gets truncated and instead of setting no-wrap to white-space we let the text wrap preserving spaces by setting whhite-space to pre-wrap Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> --------- Signed-off-by: Aneena John Xavier <aneena_john_xavier@epam.com> Co-authored-by: Ritik Jaiswal <57758447+RitikJaiswal75@users.noreply.github.com> Co-authored-by: Aneena John Xavier <aneena_john_xavier@epam.com> Co-authored-by: Sunny Sahsi <sahsisunny@gmail.com> Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com> Co-authored-by: Ajoy Kumar Das <87164140+ajoykumardas12@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the following Issues
Issue:
Multiple Assignee Tasks Search
TasksContent Component Refactor
Description:
Need to integrate multiple assignee tasks search support in frontend.
TasksContent component has become too large and contains unnecessary useState (s), resulting in hard to maintain and unnecessary re-renders. While integrating multiple assignee search support, unnecessary re-renders were causing bugs and test fail. So, have refactored the component in same PR.
Changes
Anything you would like to inform the reviewer about:
This PR addresses two issues.
Dev Tested:
Test Coverage
Images/video of the change:
2023-10-06.15-08-03.mp4
Video demonstrates multiple assignee tasks search and fixed unnecessary tasks api query.